fix(pydantic v1): more robust ModelField.annotation check
#2163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobertCraigie
changed the title
ModelField.annotation check
Merged
|
Thanks! |
stainless-app bot
pushed a commit
that referenced
this pull request
Apr 23, 2025
--------- Co-authored-by: Konnor Young <[email protected]> Co-authored-by: Robert Craigie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes being requested
Made a change to check the field_info for 'annotation' prior to accessing. In an attempt to prevent the "'ModelField' object has no attribute 'annotation'" error.
Additional context & links
closes issue #2155
The issue mentions running into this error on library version 1.52.0
I was running into this error up to version 1.65.3
pydantic version 1.9.0
python version 3.9